[PATCH] ANDROID:input:lps001wp_prs: Correct sysfs file permissions

Benn Pörscke benn.porscke at stericsson.com
Mon Feb 20 17:49:45 UTC 2012


Hi,

Good point i will check.

/Benn

On 02/20/2012 10:43 AM, Kalle Vahlman wrote:
> 2012/2/20 Benn Porscke<benn.porscke at stericsson.com>:
>> From: Benn Pörscke<benn.porscke at stericsson.com>
>>
>> ---
>>   drivers/input/misc/lps001wp_prs.c |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/input/misc/lps001wp_prs.c b/drivers/input/misc/lps001wp_prs.c
>> index 1618dfa..45a3227 100644
>> --- a/drivers/input/misc/lps001wp_prs.c
>> +++ b/drivers/input/misc/lps001wp_prs.c
>> @@ -994,7 +994,7 @@ static ssize_t attr_addr_set(struct device *dev, struct device_attribute *attr,
>>   static struct device_attribute attributes[] = {
>>         __ATTR(pollrate_ms, S_IWUSR | S_IRUGO, attr_get_polling_rate,
>>                 attr_set_polling_rate),
>> -       __ATTR(enable, S_IWUSR | S_IRUGO, attr_get_enable, attr_set_enable),
>> +       __ATTR(enable, S_IWUGO | S_IRUGO, attr_get_enable, attr_set_enable),
> Why only 'enable'? There seems to be 4 other attributes that are
> intended to be writable. Are those not interesting?
>

-- 

*Benn Pörscke*

*ST-Ericsson*

Delta 4
Scheelevägen 19 B
223 63 Lund

www.stericsson.com <http://www.stericsson.com>

Office: +46 46 10 42 58
Mobile: +46 703 68 13 30

Email: benn.porscke at stericsson.com <mailto:benn.porscke at stericsson.com>

This communication is confidential and intended solely for the 
addressee(s). Any unauthorized review, use, disclosure or distribution 
is prohibited. If you believe this message has been sent to you in 
error, please notify the sender by replying to this transmission and 
delete the message without disclosing it. Thank you. E-mail including 
attachments is susceptible to data corruption, interception, 
unauthorized amendment, tampering and viruses, and we only send and 
receive emails on the basis that we are not liable for any such 
corruption, interception, amendment, tampering or viruses or any 
consequences thereof.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://igloocommunity.org/pipermail/kernel/attachments/20120220/07eb1a5e/attachment.html>


More information about the kernel mailing list