[PATCH] ANDROID:input:lps001wp_prs: Correct sysfs file permissions

Philippe Langlais philippe.langlais at linaro.org
Mon Feb 20 10:14:06 UTC 2012


Hi Benn!

When a patch doesn't seem to be Android only specific avoids "ANDROID:" in
comment head line,
I try to have minimum differences between Generic and Android kernel and
merge this patch on common branches.

Thanks,
Philippe

On 20 February 2012 10:43, Kalle Vahlman <kalle.vahlman at movial.com> wrote:

> 2012/2/20 Benn Porscke <benn.porscke at stericsson.com>:
> > From: Benn Pörscke <benn.porscke at stericsson.com>
> >
> > ---
> >  drivers/input/misc/lps001wp_prs.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/input/misc/lps001wp_prs.c
> b/drivers/input/misc/lps001wp_prs.c
> > index 1618dfa..45a3227 100644
> > --- a/drivers/input/misc/lps001wp_prs.c
> > +++ b/drivers/input/misc/lps001wp_prs.c
> > @@ -994,7 +994,7 @@ static ssize_t attr_addr_set(struct device *dev,
> struct device_attribute *attr,
> >  static struct device_attribute attributes[] = {
> >        __ATTR(pollrate_ms, S_IWUSR | S_IRUGO, attr_get_polling_rate,
> >                attr_set_polling_rate),
> > -       __ATTR(enable, S_IWUSR | S_IRUGO, attr_get_enable,
> attr_set_enable),
> > +       __ATTR(enable, S_IWUGO | S_IRUGO, attr_get_enable,
> attr_set_enable),
>
> Why only 'enable'? There seems to be 4 other attributes that are
> intended to be writable. Are those not interesting?
>
> --
> Kalle Vahlman, Movial Creative Technologies Inc.
> Porkkalankatu 20, FI-00180 Helsinki
> Tel +358 9 8567 6400
> Fax +358 9 8567 6401
> www.movial.com
> _______________________________________________
> kernel mailing list
> kernel at igloocommunity.org
> http://igloocommunity.org/cgi-bin/mailman/listinfo/kernel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://igloocommunity.org/pipermail/kernel/attachments/20120220/73914280/attachment.html>


More information about the kernel mailing list