[PATCH] RTC: Fix to correct improper implementation of clock update irq (RTC_UIE) and enable UIE Emulation Signed-off-by: ramesh.chandrasekaran <ramesh.chandrasekaran at stericsson.com>

[Linus Walleij]

On Tue, Apr 24, 2012 at 11:11 AM, Linus Walleij
<linus.walleij at linaro.org> wrote:
> On Mon, Apr 23, 2012 at 7:55 AM, Ramesh Chandrasekaran
> <ramesh.chandrasekaran at stericsson.com> wrote:
>
>> From: ramesh.chandrasekaran <ramesh.chandrasekaran at stericsson.com>
>>
>> ---
>>  arch/arm/configs/u8500_defconfig |    1 +
>>  drivers/rtc/rtc-ab8500.c         |   15 +++++++++++++--
>>  2 files changed, 14 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/configs/u8500_defconfig b/arch/arm/configs/u8500_defconfig
>> index 2511cad..99a21e6 100644
>> --- a/arch/arm/configs/u8500_defconfig
>> +++ b/arch/arm/configs/u8500_defconfig
>> @@ -240,6 +240,7 @@ CONFIG_LEDS_TRIGGER_TIMER=y
>>  CONFIG_RTC_CLASS=y
>>  CONFIG_RTC_DRV_AB=y
>>  CONFIG_RTC_DRV_AB8500=y
>> +CONFIG_RTC_INTF_DEV_UIE_EMUL=y
>
> This is not good since it allows the user tp configure the system
> broken.
>
> Instead the Kconfig entry for the AB8500 RTC should
> select RTC_INTF_DEV_UIE_EMUL

...org maybe I'm just talking crap :-)

It seems like RTC_INTF_DEV_UIE_EMUL is going to wake up
the system every second and that sort of sucks from a power
point of view.

So adding it to the defconfig is to be considered some
"ugly-fix" for the moment?

Mattias Wallin is working on enabling the "real" RTC in
the always-on power domain, which will hopefully solve
this issue once and for all by providing a more reliable
RTC.

Yours,
Linus Walleij